Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader - scroll to the last known position only when the view first appears #1114

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Nov 14, 2024

Goal

  • The last known position is intended to take the reader to the approximate point where the user left off last time they opened the article. As of today it's triggered even when a view is pushed/popped (or presented/dismissed) on top of the reader, which is unnecessary since the system will retain the accurate position. This PR changes this behavior and uses the last known position only when the article is first opened.

fixes: #1089

Test Steps

  • Build/run
  • Open an article in the reader
  • Scroll down until you like
  • Tap on a link, if there is one available, or tap on the safari icon to reveal the original view
  • Tap "Done" to dismiss the view and make sure the previous scrolling position is maintained.
  • Go back to home or Saves
  • Reopen the article
  • Make sure the reader scrolls to a position close to the one you left off.

@Gio2018 Gio2018 added bug Something isn't working Reader labels Nov 14, 2024
@Gio2018 Gio2018 added this to the 8.21.0 milestone Nov 14, 2024
@Gio2018 Gio2018 self-assigned this Nov 14, 2024
@Gio2018 Gio2018 requested a review from bassrock as a code owner November 14, 2024 23:22
@pocket-ci
Copy link
Contributor

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 35.04%
📖 Checking XCode Environment Variables
📖 Edited 1 files
📖 Created 0 files

PocketKit: Coverage: 54.37

File Coverage
ReadableViewController.swift 65.12%

PocketKitTests: Coverage: 26.62

File Coverage
ReadableViewController.swift 54.18%

Generated by 🚫 Danger Swift against 59ab26b

@Gio2018 Gio2018 merged commit a38b750 into develop Nov 15, 2024
3 of 8 checks passed
@Gio2018 Gio2018 deleted the fix/reader-scrolls-when-it-shouldnt branch November 15, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Reader
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Opening link in reader view and returning scrolls view
3 participants