Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SwiftUI Home, Home (feature flagged) #1109

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Nov 8, 2024

Goal

  • Remove the additional SwiftUI Home tab
  • For users with the related feature flag enabled, replace UIKit Home with SwiftUI Home

Test Steps

  • Make sure Home feels like Home

@Gio2018 Gio2018 added this to the 8.21.0 milestone Nov 8, 2024
@Gio2018 Gio2018 self-assigned this Nov 8, 2024
@Gio2018 Gio2018 requested a review from bassrock as a code owner November 8, 2024 18:35
@Gio2018 Gio2018 merged commit 2e23dc5 into develop Nov 8, 2024
1 check failed
@Gio2018 Gio2018 deleted the POCKET-10794-SwiftUI-Home branch November 8, 2024 18:57
Copy link

sentry-io bot commented Nov 10, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ App Hanging Fully Blocked: App hanging for at least 2000 ms. View.banner View Issue
  • ‼️ App Hanging Fully Blocked: App hanging for at least 2000 ms. View.environmentObject<T> View Issue
  • ‼️ App Hanging Fully Blocked: App hanging for at least 2000 ms. MainView.makeUIKitHome View Issue
  • ‼️ App Hanging Fully Blocked: App hanging for at least 2000 ms. ListItem.Constants.Tags.Icon View Issue
  • ‼️ App Hanging Fully Blocked: App hanging for at least 2000 ms. HStack<T> View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants