Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwiftUI Home - Analytics #1101

Merged
merged 5 commits into from
Nov 4, 2024
Merged

SwiftUI Home - Analytics #1101

merged 5 commits into from
Nov 4, 2024

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Oct 30, 2024

Goal

  • This PR adds analytics events to SwiftUI Home

Test Steps

  • Build/run on Xcode and make sure in the console you view the same tracking events of the existing Home

@Gio2018 Gio2018 self-assigned this Oct 30, 2024
@Gio2018 Gio2018 added this to the 8.21.0 milestone Oct 30, 2024
@pocket-ci
Copy link
Contributor

pocket-ci commented Oct 30, 2024

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 36.72%
📖 Checking XCode Environment Variables
📖 Edited 17 files
📖 Created 2 files

Analytics: Coverage: 58.85

File Coverage
Home.swift 63.56%
ExpandedSlate.swift 84.44%
Collection.swift 75.43%

PocketKit: Coverage: 55.89

File Coverage
CollectionStoriesView.swift 0.0% ⚠️
CardView.swift 0.0% ⚠️
HomeViewModel.swift 65.23%
SharedWithYouView.swift 0.0% ⚠️
AnalyticsInfo.swift 0.0% ⚠️
SlateDetailView.swift 0.0% ⚠️
RecentSavesView.swift 0.0% ⚠️
SharedWithYouDetailView.swift 0.0% ⚠️
ReportRecommendationView.swift 95.83%
SlateDetailViewModel.swift 83.51%
NativeCollectionView.swift 0.0% ⚠️
CardFooter.swift 0.0% ⚠️
HomeActions.swift 0.0% ⚠️
RecommendationsView.swift 0.0% ⚠️
HomeCardConfiguration.swift 0.0% ⚠️

AnalyticsTests: Coverage: 21.57

File Coverage
Home.swift 18.22% ⚠️
ExpandedSlate.swift 33.33% ⚠️
Collection.swift 0.0% ⚠️

PocketKitTests: Coverage: 26.91

File Coverage
CollectionStoriesView.swift 0.0% ⚠️
CardView.swift 0.0% ⚠️
HomeViewModel.swift 43.94% ⚠️
SharedWithYouView.swift 0.0% ⚠️
AnalyticsInfo.swift 0.0% ⚠️
SlateDetailView.swift 0.0% ⚠️
RecentSavesView.swift 0.0% ⚠️
SharedWithYouDetailView.swift 0.0% ⚠️
ReportRecommendationView.swift 0.0% ⚠️
SlateDetailViewModel.swift 46.67% ⚠️
NativeCollectionView.swift 0.0% ⚠️
CardFooter.swift 0.0% ⚠️
HomeActions.swift 0.0% ⚠️
RecommendationsView.swift 0.0% ⚠️
HomeCardConfiguration.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 1bf4d4e

@Gio2018 Gio2018 force-pushed the POCKET-10647-SUI-analytics branch from 5dabeae to 24238d2 Compare November 1, 2024 02:14
@Gio2018 Gio2018 marked this pull request as ready for review November 1, 2024 02:14
@Gio2018 Gio2018 requested a review from bassrock as a code owner November 1, 2024 02:14
@Gio2018 Gio2018 merged commit 21b80c2 into develop Nov 4, 2024
5 of 8 checks passed
@Gio2018 Gio2018 deleted the POCKET-10647-SUI-analytics branch November 4, 2024 21:24
Copy link

sentry-io bot commented Nov 10, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ App Hanging Fully Blocked: App hanging for at least 2000 ms. Space.performAndWait<T> View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants