Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reader actions not working from SwiftUI Home #1096

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Oct 18, 2024

Goal

Fix:

  • reader save/archive button not updating after saving/archiving
  • Menu not updating accordingly after editing tags and/or highlights

Test Steps

  • Test the above actions on the reader from SwiftUI Home

@Gio2018 Gio2018 added the Reader label Oct 18, 2024
@Gio2018 Gio2018 added this to the 8.20.0 milestone Oct 18, 2024
@Gio2018 Gio2018 self-assigned this Oct 18, 2024
@Gio2018 Gio2018 requested a review from bassrock as a code owner October 18, 2024 17:39
@pocket-ci
Copy link
Contributor

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 37.69%
📖 Checking XCode Environment Variables
📖 Edited 3 files
📖 Created 0 files

PocketKit: Coverage: 57.68

File Coverage
ReaderView.swift 0.0% ⚠️
RemoteImage.swift 0.0% ⚠️
SavedItemViewModel.swift 42.77% ⚠️

PocketKitTests: Coverage: 27.79

File Coverage
ReaderView.swift 0.0% ⚠️
RemoteImage.swift 0.0% ⚠️
SavedItemViewModel.swift 22.83% ⚠️

Generated by 🚫 Danger Swift against cd9777b

@Gio2018 Gio2018 merged commit 75064b7 into develop Oct 18, 2024
5 of 8 checks passed
@Gio2018 Gio2018 deleted the POCKET-10659-reader-actions branch October 18, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants