Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Collections have missing items in certain conditions #1022

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented Jun 6, 2024

Goal

  • Fix an issue where some collections inside collections did not show as such, and were opened in a web view. That was caused by associated Items to be purged unintentionally

Test Steps

@Gio2018 Gio2018 added bug Something isn't working Native Collections labels Jun 6, 2024
@Gio2018 Gio2018 added this to the 8.11.0 milestone Jun 6, 2024
@Gio2018 Gio2018 self-assigned this Jun 6, 2024
@Gio2018 Gio2018 requested a review from bassrock as a code owner June 6, 2024 20:04
@pocket-ci
Copy link
Contributor

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 38.59%
📖 Checking XCode Environment Variables
📖 Edited 3 files
📖 Created 0 files

PocketKit: Coverage: 60.44

File Coverage
CollectionStory+Extensions.swift 0.0% ⚠️
CollectionStoryViewModel.swift 9.28% ⚠️

Sync: Coverage: 69.96

File Coverage
Space.swift 72.51%

SyncTests: Coverage: 22.82

File Coverage
Space.swift 57.32%

PocketKitTests: Coverage: 28.42

File Coverage
CollectionStory+Extensions.swift 0.0% ⚠️
CollectionStoryViewModel.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 5620501

@Gio2018 Gio2018 merged commit 30f0869 into develop Jun 6, 2024
5 of 7 checks passed
@Gio2018 Gio2018 deleted the fix/POCKET-10203-collection-item-lost branch June 6, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Native Collections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants