Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts/opt): update to new deno version #3004

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Copy link

ti-chi-bot bot commented Jun 17, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the main change here is updating the Deno version in the script. Specifically, the exec function from the deno.land/x/exec module is being replaced with Deno.Command to make use of the new API introduced in Deno. Additionally, some console logs were added to provide more information about the progress of the script.

One potential problem I see is that the sumCloc function, which is defined in the code but not used anywhere, can be safely removed to avoid confusion. Another potential issue is that the diff shows the removal of some branches in the repos array, which might cause some side effects if those branches were being used elsewhere.

As for fixing suggestions, it might be helpful to add some more details to the pull request description to explain the reasoning behind the changes and provide some context for the reviewer. It might also be a good idea to test the script with different scenarios to make sure everything is working as expected with the new Deno version. Finally, it might be worth considering reverting the changes related to the repos array if they are no longer needed.

@ti-chi-bot ti-chi-bot bot requested a review from purelind June 17, 2024 06:31
@ti-chi-bot ti-chi-bot bot added the size/M label Jun 17, 2024
@wuhuizuo wuhuizuo added the lgtm label Jun 17, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link

ti-chi-bot bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 17, 2024
@ti-chi-bot ti-chi-bot bot merged commit b617465 into main Jun 17, 2024
1 check passed
@ti-chi-bot ti-chi-bot bot deleted the fix/update-script branch June 17, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant