Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt(ti-community-infra/prow): move jobs from test-infra to prow #2990

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Copy link

ti-chi-bot bot commented Jun 12, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the title and description, this pull request moves jobs from test-infra to prow. Specifically, it updates the kustomize config to point to the new jobs and renames the jobs under the ti-community-infra/test-infra directory to ti-community-infra/prow.

There are no potential problems with this pull request, as it seems to be a straightforward renaming and updating of job locations. However, it is always good practice to review the changes and ensure that everything is working as expected.

One suggestion for improvement would be to provide a more detailed description of the changes made and why they were necessary. This would make it easier for other team members to understand the purpose of the pull request and the reasoning behind the changes.

Overall, this pull request seems to be a simple and necessary update to the job configurations.

@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link

ti-chi-bot bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit c62d1a7 into main Jun 12, 2024
1 of 2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/prow-repo-jobs branch June 12, 2024 08:31
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants