Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt(pingcap/tidb-dashboard): speedup image building fo linux/arm64 target #2989

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

wuhuizuo
Copy link
Collaborator

Signed-off-by: wuhuizuo wuhuizuo@126.com

…rget

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind June 12, 2024 07:55
Copy link

ti-chi-bot bot commented Jun 12, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the title and the description of the Pull Request, it seems that the key change is to speed up the image building process for linux/arm64 target by using a pre-built Docker image from ghcr.io/pingcap-qe/cd/builders/tidb-dashboard.

Overall, the changes look good. By using a pre-built Docker image, the build process will be faster and more efficient. However, there are some suggestions for further improvement:

  1. The Dockerfile in the diff does not seem to reflect the changes mentioned in the Pull Request. It still uses the original centos:7 base image and installs Golang, Node.js, and Java, which are not needed if using a pre-built image. The original Dockerfile should be removed or updated to reflect the changes.
  2. It would be helpful to add some comments in the Jenkinsfile explaining the changes and the reasons behind them to make it easier for future maintainers to understand the code.
  3. It would be good to test the changes locally before merging the Pull Request to ensure that everything works as expected.

Overall, the changes look good, and once the Dockerfile and Jenkinsfile are updated, the Pull Request can be merged.

@ti-chi-bot ti-chi-bot bot added the size/M label Jun 12, 2024
@wuhuizuo
Copy link
Collaborator Author

@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link

ti-chi-bot bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 12, 2024
@wuhuizuo wuhuizuo added the lgtm label Jun 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7aa4aae into main Jun 12, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/fast-tidb-dashboard-building branch June 12, 2024 08:10
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants