Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tikv-pd): use prow style job in 6.1 #2987

Merged

Conversation

purelind
Copy link
Collaborator

use prow style job in 6.1

Copy link

ti-chi-bot bot commented Jun 11, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes aim to update the job style in the 6.1 release of the tikv-pd project to use the Prow style job.

The changes include:

  • Removing the disabled flag in the pd_ghpr_build job.
  • Updating the tikv/pd/release-6.1-presubmits.yaml file to include the new Prow style job.

The changes seem straightforward and do not appear to introduce any potential problems. However, there are a few suggestions that could be considered for improvement:

  • The context field in the tikv/pd/release-6.1-presubmits.yaml file could be more descriptive to better reflect the purpose of the job.
  • It would be helpful to add more details to the pull request description to explain the reason for the changes, such as any benefits or performance improvements that the new job style provides.

Overall, the changes seem reasonable and can be merged.

Copy link

ti-chi-bot bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 11, 2024
Copy link

ti-chi-bot bot commented Jun 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-11 03:31:17.144661887 +0000 UTC m=+435431.197973812: ☑️ agreed by wuhuizuo.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 11, 2024
@ti-chi-bot ti-chi-bot bot merged commit 016910c into PingCAP-QE:main Jun 11, 2024
2 checks passed
@purelind purelind deleted the purelind/use-prow-jobs-on-pd-6.1 branch June 11, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants