-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dot aliases #117
Remove dot aliases #117
Conversation
Nice! Are you able to generate the exact same protocol files with the changed generator? I've updated to use
Seems like the generator needs updating? Did you resolve this problem? |
I did manage to generate and create the same files (except for the order of imports in one file, which i just updated with 3be6bb0). I also could not get it to work with the latest proco-gen-go, i had to downgrade to the version in the readme with |
Thanks. I rolled back to the old versions of - BalanceUrl *string `protobuf:"bytes,10,opt,name=balance_url,json=balanceUrl" json:"balance_url,omitempty"`
- TxnCountryCode *string `protobuf:"bytes,11,opt,name=txn_country_code,json=txnCountryCode" json:"txn_country_code,omitempty"`
+ BalanceUrl *string `protobuf:"bytes,10,opt,name=balance_url" json:"balance_url,omitempty"`
+ TxnCountryCode *string `protobuf:"bytes,11,opt,name=txn_country_code" json:"txn_country_code,omitempty"` Are you using precisely |
Yep, think you're right, i was using the protoc-gen-go version from the readme but using the latest version of protoc. I think the latest generated code was actually generated with a version later than the readme. Might be easier just to update the readme to allow for a later protoc? |
I've updated to reference to the protoc version in 8da11b6. Thanks for your work, merged! |
As mentioned in #116 (comment), this PR removes all dot imports.