This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Added `get_total_parameters` + Remove `Dataset` in favor of third party libraries like pandas + Fix tests for `smt` dataset + Fix `snli` example + Remove `datasets_iterator` in favor of Python `itertools.chain` + Remove `torchnlp.utils.shuffle` in favor of `torchnlp.random`
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
==========================================
+ Coverage 94.17% 94.41% +0.24%
==========================================
Files 57 63 +6
Lines 1545 1594 +49
==========================================
+ Hits 1455 1505 +50
+ Misses 90 89 -1
Continue to review full report at Codecov.
|
+ Quick __init__ fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes come after using the library for another couple months at https://wellsaidlabs.com/
Major Changes
torchnlp.random
enabling control overnumpy
,torch
, andrandom
states.samplers
to be more flexible and extensible.Minor Changes
stoi
anditos
stack_and_pad_tensors
returns anamedtuple
torchnlp.datasets.Dataset
in favor of third party libraries likepandas
torchnlp.utils.datasets_iterator
in favor of Pythonsitertools.chain
.torchnlp.utils.shuffle
in favor oftorchnlp.random
examples/snli
torch.utils.get_total_parameters
torch.utils.resplit_datasets
in favor oftorch.utils.split_list
andtorchnlp.random
.pandas
andrequests
as dependencies, slimming the package down