Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local data variable in DS2 data generator. #199

Merged
merged 2 commits into from
Aug 14, 2017

Conversation

wanghaoshuang
Copy link
Contributor

Move local data variable from global into class DataGenerator.
fix #198

@wanghaoshuang wanghaoshuang self-assigned this Aug 14, 2017
Copy link
Contributor

@xinghai-sun xinghai-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM.

@@ -89,6 +84,10 @@ def __init__(self,
self._num_threads = num_threads
self._rng = random.Random(random_seed)
self._epoch = 0
# for caching tar files info
self.local_data = local()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.local_data --> self._local_data

@wanghaoshuang wanghaoshuang merged commit 9538238 into PaddlePaddle:develop Aug 14, 2017
@wanghaoshuang wanghaoshuang deleted the fix_ds2_reader branch August 14, 2017 11:46
@wanghaoshuang wanghaoshuang restored the fix_ds2_reader branch August 14, 2017 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DS2 reader: Move local data variable from global into class DataGenerator.
2 participants