Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

[CRC] add docstring for VariableCreator, SpecialInferMeta and symbolic_translate #191

Merged
merged 6 commits into from
Jun 26, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jun 22, 2023

Add comments for VariableCreator\SpecialInferMeta\symbolic_translate

#186

@paddle-bot
Copy link

paddle-bot bot commented Jun 22, 2023

Thanks for your contribution!

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jun 22, 2023
sot/infer_meta.py Outdated Show resolved Hide resolved
sot/infer_meta.py Outdated Show resolved Hide resolved
sot/translate.py Outdated Show resolved Hide resolved
sot/translate.py Outdated Show resolved Hide resolved
sot/translate.py Outdated Show resolved Hide resolved
@SigureMo
Copy link
Member

另外按照 #186 4.3 加一下类型提示吧

@enkilee
Copy link
Contributor Author

enkilee commented Jun 23, 2023

收到,谢谢

@enkilee
Copy link
Contributor Author

enkilee commented Jun 23, 2023

@SigureMo 跪求大佬提示

@SigureMo SigureMo requested review from SigureMo and removed request for SigureMo June 23, 2023 11:29
@SigureMo SigureMo changed the title Add comment for VariableCreator\SpecialInferMeta\symbolic_translate [CRC] Add docstring for VariableCreator\SpecialInferMeta\symbolic_translate Jun 24, 2023
@SigureMo SigureMo changed the title [CRC] Add docstring for VariableCreator\SpecialInferMeta\symbolic_translate [CRC] add docstring for VariableCreator, SpecialInferMeta and symbolic_translate Jun 24, 2023
Copy link
Collaborator

@feifei-111 feifei-111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@SigureMo SigureMo merged commit 23a9854 into PaddlePaddle:develop Jun 26, 2023
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR status: proposed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants