[Trainer] update clear_grad #8829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
DesmonDay
force-pushed
the
add_clear_grad
branch
2 times, most recently
from
97eb19d to
19311b5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8829 +/- ##
===========================================
+ Coverage 55.44% 55.51% +0.07%
===========================================
Files 631 631
Lines 98542 98545 +3
===========================================
+ Hits 54632 54710 +78
+ Misses 43910 43835 -75 ☔ View full report in Codecov by Sentry. |
ZHUI
reviewed
Jul 30, 2024
| @@ -355,6 +355,8 @@ class TrainingArguments: | |||
| Whether skip profile timer, timer will record time usage of forward/ backward/ step, etc. | |||
| distributed_dataloader (`bool`, *optional*): | |||
| Whether to use distributed dataloader. Default is `False`. | |||
| release_grads (`bool`, *optional*): | |||
| Whether to release gradients during training. Default is `False`. | |||
There was a problem hiding this comment.
DesmonDay
force-pushed
the
add_clear_grad
branch
from
19311b5 to
45e8afd
Compare
DrownFish19
pushed a commit
to DrownFish19/PaddleNLP
that referenced
this pull request
Aug 2, 2024
DrownFish19
pushed a commit
to DrownFish19/PaddleNLP
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
Set self.optimizer.clear_grad(set_to_zero=False).