Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect mdrst #8667

Merged
merged 2 commits into from
Mar 1, 2018
Merged

Fix incorrect mdrst #8667

merged 2 commits into from
Mar 1, 2018

Conversation

jetfuel
Copy link
Contributor

@jetfuel jetfuel commented Mar 1, 2018

RST ordered list needs to type out the number manually.

MD:
If the ordered list is not indented, there should be an empty line before the list block.

fixes /~https://github.com/PaddlePaddle/PaddlePaddle.org/issues/424
fixes /~https://github.com/PaddlePaddle/PaddlePaddle.org/issues/423

@jetfuel jetfuel self-assigned this Mar 1, 2018
@jetfuel jetfuel requested a review from luotao1 March 1, 2018 00:14
@CLAassistant
Copy link

CLAassistant commented Mar 1, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks very much!

@luotao1 luotao1 merged commit 5388375 into develop Mar 1, 2018
@jetfuel jetfuel deleted the fixIncorrectMDRST branch March 1, 2018 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants