Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parallel-do should not merge the gradient of parameter that stop_gradient=True #8652

Merged
merged 4 commits into from
Feb 28, 2018
Merged

parallel-do should not merge the gradient of parameter that stop_gradient=True #8652

merged 4 commits into from
Feb 28, 2018

Conversation

jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Feb 28, 2018 •
edited
Loading

fix: #8653

@jacquesqiao jacquesqiao mentioned this pull request Feb 28, 2018
Closed
reyoung
reyoung approved these changes Feb 28, 2018
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@jacquesqiao jacquesqiao merged commit be9a2b2 into PaddlePaddle:develop Feb 28, 2018
@jacquesqiao jacquesqiao mentioned this pull request Mar 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyoung reyoung reyoung approved these changes

@tonyyang-svail tonyyang-svail Awaiting requested review from tonyyang-svail

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parallel-do should not merge gradient of parameter which set stop_gradient=True
2 participants
@jacquesqiao @reyoung