merge fluid dist tests #8573
Merged
merge fluid dist tests #8573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongweibao
previously approved these changes
Feb 26, 2018
| if is_local: | ||
| train_loop(fluid.default_main_program()) | ||
| else: | ||
| port = os.getenv("PADDLE_INIT_PORT", "6174") |
There was a problem hiding this comment.
There was a problem hiding this comment.
Thought both ways are OK, PADDLE_INIT_PORT is also used in v2 when calling paddle.init()
Yancey1989
reviewed
Feb 27, 2018
| raise AssertionError("Fit a line cost is too large, {0:2.2}".format( | ||
| avg_loss_value[0])) | ||
|
|
||
| if is_local: |
There was a problem hiding this comment.
Is is_local necessary? We can run the local mode with the code under book directory.
There was a problem hiding this comment.
Got it, this PR merge book and book_dist folder.
Yancey1989
previously approved these changes
Feb 27, 2018
… fix_dist_demos
typhoonzero
dismissed stale reviews from Yancey1989 and gongweibao
via
0c4714a
… fix_dist_demos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8571
Fix #8598