Correctly handling variable with batch dimension for math ops. #8505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should allow addition like the following where b is a scalar for each instance in a batch, although both
a
andb
has an additional batch dimension. The following code will cause error with the current implementation of math_op_patch.py.To fix this, we need to set the axis to 0 when the second argument contains batch dimension.
Also makes elementwise ops more tolerant at handling tensors with trailing singular dimensions.
Also added Dim<0>. Dim<0> is for scalar (rank-0 tensor). Adding Dim<0> can simplify a lot of code.