Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bring back test_parallel_do #7676

Merged
merged 1 commit into from
Jan 19, 2018
Merged

bring back test_parallel_do #7676

merged 1 commit into from
Jan 19, 2018

Conversation

tonyyang-svail
Copy link

fix #7673

tonyyang-svail
tonyyang-svail commented Jan 19, 2018
View reviewed changes
paddle/operators/parallel_do_op.cc
@@ -214,6 +220,7 @@ class ParallelDoGradOp : public framework::OperatorBase {
auto &tensor_to_merge = sub_scopes[i]->FindVar(s)->Get<LoDTensor>();
if (!(places[i] == places[0])) {
framework::Copy(tensor_to_merge, places[0], tmp);
WaitOnPlace(places[0]);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to wait after copy

reyoung
reyoung approved these changes Jan 19, 2018
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

However, we should provide a unified design for waiting for GPU stream and multiple streams.

@reyoung reyoung merged commit 259fcc3 into PaddlePaddle:develop Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyoung reyoung reyoung approved these changes

@dzhwinter dzhwinter Awaiting requested review from dzhwinter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bring back test_parallel_do
2 participants
@tonyyang-svail @reyoung