update new_op doc #7672
Merged
update new_op doc #7672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcy-seso
reviewed
Jan 19, 2018
doc/howto/dev/new_op_en.md
Outdated
|
|
||
| An operator can be differentiated by whether in has kernel methods. An operator with kernel inherits from `OperatorWithKernel` while the ones without inherit from `OperatorBase`. This tutorial focuses on implementing operators with kernels. In short, an operator includes the following information: | ||
| An operator can be differentiated by whether in has computation kernels. An operator with kernel inherits from `OperatorWithKernel` while the ones without inherit from `OperatorBase`. This tutorial focuses on implementing operators with kernels. In short, an operator includes the following information: |
There was a problem hiding this comment.
- The first sentence: Operators can be categorized into two groups: operator with kernel(s) and operator without kernel(s).
- "An operator with kernel inherits from
OperatorWithKernelwhile the ones without inheriting fromOperatorBase." --> An operator with kernel(s) inherits fromOperatorWithKernelwhile the one without kernel(s) inherits fromOperatorBase.
There was a problem hiding this comment.
第37行的markdown标记有问题。
** The system will use the naming scheme to automatically build operators and their corresponding Python extensions. ** ，** 之后的空格应该去掉。
| @@ -225,6 +230,7 @@ The definition of its corresponding backward operator, if applicable, is similar | |||
| Run the following commands to compile. | |||
|
|
|||
| ``` | |||
| # maybe you need to rerun cmake | |||
There was a problem hiding this comment.
you may need to rerun cmake.
lcy-seso
approved these changes
Jan 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #7674