[SOT][Faster Guard] add some basic guard #69313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo
reviewed
Nov 12, 2024
paddle/fluid/pybind/jit.cc
Outdated
Comment on lines
113
to
146
| py::class_<GuardBase, std::shared_ptr<GuardBase>>( | ||
| *m, "GuardBase", R"DOC(GuardBase Class.)DOC") | ||
| .def("check", &GuardBase::check_pybind); | ||
| py::class_<LambdaGuard, GuardBase, std::shared_ptr<LambdaGuard>>( | ||
| *m, "LambdaGuard", R"DOC(LambdaGuard Class.)DOC") | ||
| .def(py::init<const py::function &>(), py::arg("guard_check_fn")); | ||
| py::class_<GuardGroup, GuardBase, std::shared_ptr<GuardGroup>>( | ||
| *m, "GuardGroup", R"DOC(GuardGroup Class.)DOC") | ||
| .def(py::init<std::vector<std::shared_ptr<GuardBase>>>(), | ||
| py::arg("guards")); | ||
| py::class_<TypeMatchGuard, GuardBase, std::shared_ptr<TypeMatchGuard>>( | ||
| *m, "TypeMatchGuard", R"DOC(TypeMatchGuard Class.)DOC") | ||
| .def(py::init<const py::type &>(), py::arg("py_type")); | ||
| py::class_<LengthMatchGuard, GuardBase, std::shared_ptr<LengthMatchGuard>>( | ||
| *m, "LengthMatchGuard", R"DOC(LengthMatchGuard Class.)DOC") | ||
| .def(py::init<Py_ssize_t>(), py::arg("length")); | ||
| py::class_<ValueMatchGuard, GuardBase, std::shared_ptr<ValueMatchGuard>>( | ||
| *m, "ValueMatchGuard", R"DOC(ValueMatchGuard Class.)DOC") | ||
| .def(py::init<const py::object &>(), py::arg("py_value")); | ||
| py::class_<DtypeMatchGuard, GuardBase, std::shared_ptr<DtypeMatchGuard>>( | ||
| *m, "DtypeMatchGuard", R"DOC(DtypeMatchGuard Class.)DOC") | ||
| .def(py::init<const paddle::framework::proto::VarType &>(), | ||
| py::arg("dtype")) | ||
| .def(py::init<const phi::DataType &>(), py::arg("dtype")); | ||
| py::class_<LayerMatchGuard, GuardBase, std::shared_ptr<LayerMatchGuard>>( | ||
| *m, "LayerMatchGuard", R"DOC(LayerMatchGuard Class.)DOC") | ||
| .def(py::init<const py::object &>(), py::arg("layer_obj")); | ||
|
|
||
| m->def( | ||
| "merge_guard", | ||
| [](const std::vector<std::shared_ptr<GuardBase>> &py_guards) { | ||
| return GuardGroup(py_guards); | ||
| }, | ||
| py::arg("py_guards")); |
There was a problem hiding this comment.
这块可以抽一个函数叫 BindGuard，这里直接调用下就好了
SigureMo
reviewed
Nov 12, 2024
| @@ -61,6 +61,43 @@ void BindJit(pybind11::module *m) { | |||
| }); | |||
| } | |||
|
|
|||
| void BindGuard(pybind11::module *m) { | |||
There was a problem hiding this comment.
这块也要放到 SOT_IS_SUPPORTED 里，不然编译 Python 3.14 GuardGroup 等会找不到
SigureMo
approved these changes
Nov 12, 2024
|
相关 PR 链接下 #69264 |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Performance
Description
在C++端添加了一些基础的 guard并添加了一些单元测试