Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine install docs #5943

Merged
merged 4 commits into from
Nov 29, 2017
Merged

Refine install docs #5943

merged 4 commits into from
Nov 29, 2017

Conversation

typhoonzero
Copy link
Contributor

Fix #5941

luotao1
luotao1 reviewed Nov 28, 2017
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc/howto/dev/build_cn.md和doc/howto/dev/build_en.md可以先保留么，待挪到BLOG后再删除？

doc/getstarted/build_and_install/build_from_source_cn.rst Outdated

.. code-block:: bash

docker run -it -v $PWD:/paddle -e "WITH_GPU=OFF" -e "WITH_TESTING=OFF" -e "RUN_TEST=ON" paddlepaddle/paddle_manylinux_devel:cuda8.0_cudnn5 bash -x paddle/scripts/docker/build.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • WITH_TESTING和RUN_TEST是什么关系呢，为什么一个是OFF，一个是ON？
  • WITH_GPU=OFF的话，只能测试cpu的单测，gpu的单测测不了，是不是要和用户说一下？

doc/getstarted/build_and_install/build_from_source_cn.rst

mkdir build
cd build
cmake -DWITH_GPU=OFF -DWITH_TESTING=OFF ..
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • DWITH_TESTING=OFF应该是ON吧。
  • ctest的命令，还可以用make test ARG='-j 4'，可以一起加上么？
  • 这里只列出了跑所有单测的命令，还可以加上跑指定单测的命令：make test ARGS="-R test_mul_op -V"和ctest -R test_mul_op

参考：/~https://github.com/PaddlePaddle/Paddle/blob/develop/doc/howto/dev/new_op_cn.md#编译和执行单元测试

Copy link
Contributor Author

@typhoonzero typhoonzero Nov 28, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ctest的命令，还可以用make test ARG='-j 4'，可以一起加上么？

这个感觉不用吧，只保留一种执行test的方式，避免费解。

其他的Comments都更新了。感谢Review~

doc/getstarted/build_and_install/build_from_source_cn.rst Outdated
可以在 `这里 <https://hub.docker.com/r/paddlepaddle/paddle_manylinux_devel/tags/>`_ 找到。

如果您选择不使用Docker镜像，则需要在本机安装下面章节列出的“编译依赖”之后才能开始编译的步骤。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“编译依赖” 这里可以加链接么？即直接跳转到后面的内容

luotao1
luotao1 approved these changes Nov 29, 2017
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！Thanks very much!

@typhoonzero typhoonzero merged commit 0c0ff28 into PaddlePaddle:develop Nov 29, 2017
@typhoonzero typhoonzero deleted the refine_docs2 branch December 22, 2017 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@typhoonzero @luotao1