Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete shrink_rnn_memory_op comments #5935

Merged
merged 2 commits into from
Nov 27, 2017
Merged

Complete shrink_rnn_memory_op comments #5935

merged 2 commits into from
Nov 27, 2017

Conversation

JiayiFeng
Copy link
Collaborator

No description provided.

@JiayiFeng JiayiFeng requested review from reyoung and QiJune November 27, 2017 07:12
QiJune
QiJune approved these changes Nov 27, 2017
View reviewed changes
Copy link
Member

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiayiFeng JiayiFeng merged commit 90fc4a6 into PaddlePaddle:develop Nov 27, 2017
@JiayiFeng JiayiFeng deleted the complete_shrink_rnn_memory_op_comments branch November 27, 2017 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QiJune QiJune QiJune approved these changes

@reyoung reyoung Awaiting requested review from reyoung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiayiFeng @QiJune