fix v2 init issue on Mac #5808
fix v2 init issue on Mac #5808
Conversation
python/paddle/v2/__init__.py
Outdated
| # do not support on other platform yet | ||
| return False | ||
|
|
||
| def get_logical_processors(): |
There was a problem hiding this comment.
This function returns the number of logical processors, other than a list of logical processors, so it should be named either get_num_logical_processor or num_logical_processor. Otherwise, we'd lose the most important concept "number".
There was a problem hiding this comment.
Got it, thanks, I will use num_logical_processor instead.
python/paddle/v2/__init__.py
Outdated
| '''Get the logical processors number''' | ||
| import platform | ||
| if platform.system() == "Linux": | ||
| processors = os.popen( |
There was a problem hiding this comment.
Similarly, processors => num_proc or num_processors.
python/paddle/v2/__init__.py
Outdated
| return int(processors.read()) | ||
| else: | ||
| # do not support on other platform yet | ||
| return 1 |
There was a problem hiding this comment.
I think this function definition (26 lines, from L82 to L108) can be significantly shortened (into 4 lines) while keeping the readability:
def num_logical_processor():
cmds = { "Linux" : "grep \"processor\" /proc/cpuinfo|sort -u|wc -l",
"Darwin" : "sysctl hw.logicalcpu" }
return int(os.popen(cmds.get(platform.system(), "expr 1")).read())
python/paddle/v2/__init__.py
Outdated
| for key in args_dict.keys(): | ||
| args.append('--%s=%s' % (key, str(args_dict[key]))) | ||
|
|
||
| auto_set_cpu_env(kwargs.get('trainer_count', 1)) |
There was a problem hiding this comment.
All programs, including auto_set_cpu_env, were written to do something automatically, so it seems that an accurate name could be set_omp_mkl_env_vars.
python/paddle/v2/__init__.py
Outdated
| # do not support on other platform yet | ||
| return False | ||
|
|
||
| def get_logical_processors(): |
There was a problem hiding this comment.
Got it, thanks, I will use num_logical_processor instead.
python/paddle/v2/__init__.py
Outdated
| '''Get the logical processors number''' | ||
| import platform | ||
| if platform.system() == "Linux": | ||
| processors = os.popen( |
python/paddle/v2/__init__.py
Outdated
| return int(processors.read()) | ||
| else: | ||
| # do not support on other platform yet | ||
| return 1 |
python/paddle/v2/__init__.py
Outdated
| for key in args_dict.keys(): | ||
| args.append('--%s=%s' % (key, str(args_dict[key]))) | ||
|
|
||
| auto_set_cpu_env(kwargs.get('trainer_count', 1)) |
|
Have tested on Mac, v2 Python API is fine. |
fix #5801
hi @jacquesqiao I do not have mac to test, so could u help?
I have already verified it on Linux, and it works.