Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MarkTrtEngineOutputs API #56188

Merged
merged 7 commits into from
Aug 17, 2023
Merged

Add MarkTrtEngineOutputs API #56188

merged 7 commits into from
Aug 17, 2023

Conversation

ming1753
Copy link
Contributor

PR types

Others

PR changes

Others

Description

Pcard-71501

  1. 添加了一个新的和TRT相关API：MarkTrtEngineOutputs，用来获取Engine的中间输出，实现trt精度调试。
    参数：output_tensor_names：指明需要标记的Tensor的name，默认output_tensor_names为空。
  2. 修复了RegisterOutputHook同一个进程的不同predictor只有第一个起作用的bug。

@paddle-bot
Copy link

paddle-bot bot commented Aug 11, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@ming1753 ming1753 changed the title Result fix Add MarkTrtEngineOutputs API Aug 11, 2023
XieYunshen
XieYunshen approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
单测执行时间设置

qingqing01
qingqing01 approved these changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But need to add docs for this API in Paddle-Inference-Demo repo

jzhang533
jzhang533 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for API change

@Wangzheee Wangzheee merged commit 2abf432 into PaddlePaddle:develop Aug 17, 2023
@ming1753 ming1753 mentioned this pull request Aug 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XieYunshen XieYunshen XieYunshen approved these changes

@qingqing01 qingqing01 qingqing01 approved these changes

@jzhang533 jzhang533 jzhang533 approved these changes

Assignees

@jzhang533 jzhang533

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ming1753 @jzhang533 @qingqing01 @XieYunshen @Wangzheee