Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][CINN] fix Ruff lint errors (flake8-comprehensions rules) #55087

Merged
merged 4 commits into from
Jul 4, 2023
Merged

[CodeStyle][CINN] fix Ruff lint errors (flake8-comprehensions rules) #55087

merged 4 commits into from
Jul 4, 2023

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jul 3, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

C408:
fix 30
dict -> {} 20
list - > [] 10

C416:
fix 1
[line for line in sys.stdin] -> list(sys.stdin)

C417:
fix 2

@paddle-bot
Copy link

paddle-bot bot commented Jul 3, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Jul 3, 2023
@enkilee enkilee changed the title [CodeStyle][CINN] fix Ruff flake8-comprehensions errors ('C408','C416','C417') [CodeStyle][CINN] fix Ruff flake8-comprehensions errors 'C408','C416','C417') Jul 3, 2023
@enkilee enkilee changed the title [CodeStyle][CINN] fix Ruff flake8-comprehensions errors 'C408','C416','C417') [CodeStyle][CINN] fix Ruff flake8-comprehensions errors 'C408','C416','C417' Jul 3, 2023
@enkilee enkilee changed the title [CodeStyle][CINN] fix Ruff flake8-comprehensions errors 'C408','C416','C417' [CodeStyle][CINN] fix Ruff flake8-comprehensions errors C408,C416,C417 Jul 3, 2023
@SigureMo
Copy link
Member

SigureMo commented Jul 3, 2023

image

@SigureMo SigureMo changed the title [CodeStyle][CINN] fix Ruff flake8-comprehensions errors C408,C416,C417 [CodeStyle][CINN] fix Ruff lint errors (flake8-comprehensions rules) Jul 3, 2023
@SigureMo SigureMo mentioned this pull request Jul 3, 2023
Closed
SigureMo
SigureMo reviewed Jul 3, 2023
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jul 3, 2023
SigureMo
SigureMo previously approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

需要 rerun 下 PR-CI-Coverage

@SigureMo
Copy link
Member

SigureMo commented Jul 4, 2023

麻烦解决下冲突

@enkilee
Copy link
Contributor Author

enkilee commented Jul 4, 2023

已解决冲突

@enkilee enkilee requested a review from SigureMo July 4, 2023 04:22
SigureMo
SigureMo approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit df6c74c into PaddlePaddle:develop Jul 4, 2023
@enkilee enkilee deleted the codestyle-ruff-flake8 branch July 6, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SigureMo SigureMo SigureMo approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enkilee @SigureMo @luotao1