Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMP Prim OP]support bf16 dtype for layer_norm prim op #54236

Merged
merged 5 commits into from
Jun 1, 2023
Merged

[AMP Prim OP]support bf16 dtype for layer_norm prim op #54236

merged 5 commits into from
Jun 1, 2023

Conversation

Charles-hit
Copy link
Contributor

PR types

Others

PR changes

Others

Description

Pcard-66975
PR改动：

  • 为layer_norm前向拆解新增amp逻辑，保持跟原有kernel行为一致。
  • 为layer_norm反向拆解新增amp逻辑，保持跟原有kernel行为一致，并解决拆解的精度问题。
  • 为layer_norm原生算子和组合算子添加bf16单测。

@paddle-bot
Copy link

paddle-bot bot commented May 31, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented May 31, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

ZzSean
ZzSean approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cyber-pioneer
cyber-pioneer approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@cyber-pioneer cyber-pioneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xiaoguoguo626807
xiaoguoguo626807 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XieYunshen
XieYunshen approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
单测超时时间设置

@Charles-hit Charles-hit merged commit e3fcbb8 into PaddlePaddle:develop Jun 1, 2023
@Charles-hit Charles-hit deleted the support_bf16_for_layer_norm_prim_op branch June 1, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyber-pioneer cyber-pioneer cyber-pioneer approved these changes

@xiaoguoguo626807 xiaoguoguo626807 xiaoguoguo626807 approved these changes

@XieYunshen XieYunshen XieYunshen approved these changes

@ZzSean ZzSean ZzSean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Charles-hit @ZzSean @XieYunshen @xiaoguoguo626807 @cyber-pioneer