Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update_c++17 #53892

Merged
merged 61 commits into from
May 30, 2023
Merged

update_c++17 #53892

merged 61 commits into from
May 30, 2023

Conversation

risemeup1
Copy link
Contributor

@risemeup1 risemeup1 commented May 17, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Description

Pcard-67010
此PR将linux和mac下的C++标准从14升级到17，同步CUDA跟CPP使用C++标准都为C++17，windows之前已升级(#53958)

To do：

  • CINN流水线有几个单测失败，待修复后，CINN下也切换C++17

主要修复了5类问题：

  • gcc对C++17标准在链接库文件时候检查依赖关系更为严格，应该将提供符号的库文件放在使用符号的库文件后面，即越基础的库文件越应该放在后边；
  • 修复Paddle的一些CMake中静态库写的不规范，缺少依赖或顺序颠倒，导致链接阶段会暴露大量的undefined reference to "xxxx"的bug；
    dc788e56393c2ccbd1ec512860cab266
  • 修复单测ctr_accessor_test和ctr_dymf_accessor_test因为强符号报错重定义(multiple definition of 'xxx')的问题；
image
  • 修复了一些语法不规范的问题以及对pocketfft第三方库打补丁修复在C++17下找不到aligned_alloc的bug。
    image
  • C++17在对智能指针花括号赋值时，出现无法识别{的情况，将变量inplace_version_counter识别为inpacle_version_counter_std ，改变初始构造方式可以解决此问题
    image

@paddle-bot
Copy link

paddle-bot bot commented May 17, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented May 17, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@risemeup1 risemeup1 force-pushed the update_c++17 branch 2 times, most recently from 286e2d6 to 4d50f1b Compare May 18, 2023 02:28
XiaoguangHu01
XiaoguangHu01 approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tianshuo78520a
tianshuo78520a approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@tianshuo78520a tianshuo78520a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

YuanRisheng
YuanRisheng approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@YuanRisheng YuanRisheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhangbo9674
zhangbo9674 approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@zhangbo9674 zhangbo9674 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit 950b563 into PaddlePaddle:develop May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyfncg zyfncg zyfncg approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@tianshuo78520a tianshuo78520a tianshuo78520a approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@zhangbo9674 zhangbo9674 zhangbo9674 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@risemeup1 @zyfncg @YuanRisheng @tianshuo78520a @XiaoguangHu01 @zhangbo9674