-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support static graph code-gen for unpool #52947
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
paddle/phi/api/yaml/ops.yaml
Outdated
@@ -1986,6 +1986,16 @@ | |||
data_type : x | |||
optional : index, counts | |||
|
|||
- op : unpool | |||
args: (Tensor x, Tensor indices, int[] ksize, int[] strides = {1,1}, int[] padding ={0,0}, str unpooling_type = {"max"} ,IntArray output_size = {0,0}, str data_format="NCHW") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
目前看unpooling_type
没有在infershape中使用,也没有在kernel中使用,先尝试删除这个配置
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
目前看
unpooling_type
没有在infershape中使用,也没有在kernel中使用,先尝试删除这个配置
好的,不过cc有,那我就删掉了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unpool_sig.cc
和unpool_op.cc
中关于unpool
的相关代码要删除
paddle/phi/api/yaml/ops.yaml
Outdated
@@ -2012,6 +2012,16 @@ | |||
data_type : x | |||
optional : index, counts | |||
|
|||
- op : unpool | |||
args: (Tensor x, Tensor indices, int[] ksize, int[] strides = {1,1}, int[] padding ={0,0} ,IntArray output_size = {0,0}, str data_format="NCHW") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strides = {1,1}
,这里的逗号是不是写成中文的逗号了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还真是。。。心态崩了= =
inputs : | ||
{x : X, indices: Indices} | ||
outputs : | ||
out : Out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
配置:
int_array :
output_size:
data_type : int
support_tensor : true
对应到.cc中的这里SupportTensor
这句话。
paddle/phi/api/yaml/ops.yaml
Outdated
@@ -2012,6 +2012,16 @@ | |||
data_type : x | |||
optional : index, counts | |||
|
|||
- op : unpool | |||
args: (Tensor x, Tensor indices, int[] ksize, int[] strides = {1,1}, int[] padding ={0,0} ,IntArray output_size = {0,0}, str data_format="NCHW") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
padding
修改为paddings
目前没什么问题,请rerun一下失败的PR,尤其是 |
return还是挂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Description
#51842
根据op.cc需要增加参数 unpooling_type
但是infermeta没有考虑到这个