Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support static graph code-gen for unpool #52947

Merged
merged 7 commits into from
Apr 28, 2023

Conversation

sanbuphy
Copy link
Contributor

@sanbuphy sanbuphy commented Apr 15, 2023

PR types

Others

PR changes

Others

Description

#51842

根据op.cc需要增加参数 unpooling_type
但是infermeta没有考虑到这个

@paddle-bot
Copy link

paddle-bot bot commented Apr 15, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -1986,6 +1986,16 @@
data_type : x
optional : index, counts

- op : unpool
args: (Tensor x, Tensor indices, int[] ksize, int[] strides = {1,1}, int[] padding ={0,0}, str unpooling_type = {"max"} ,IntArray output_size = {0,0}, str data_format="NCHW")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前看unpooling_type没有在infershape中使用,也没有在kernel中使用,先尝试删除这个配置

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前看unpooling_type没有在infershape中使用,也没有在kernel中使用,先尝试删除这个配置

好的,不过cc有,那我就删掉了

@sanbuphy sanbuphy requested a review from heavyrain-lzy April 18, 2023 06:25
Copy link
Contributor

@heavyrain-lzy heavyrain-lzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unpool_sig.ccunpool_op.cc中关于unpool的相关代码要删除

@sanbuphy sanbuphy requested a review from heavyrain-lzy April 20, 2023 07:57
@@ -2012,6 +2012,16 @@
data_type : x
optional : index, counts

- op : unpool
args: (Tensor x, Tensor indices, int[] ksize, int[] strides = {1,1}, int[] padding ={0,0} ,IntArray output_size = {0,0}, str data_format="NCHW")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strides = {1,1},这里的逗号是不是写成中文的逗号了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还真是。。。心态崩了= =

inputs :
{x : X, indices: Indices}
outputs :
out : Out
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

配置:

int_array : 
  output_size:
    data_type : int
    support_tensor : true

对应到.cc中的这里SupportTensor这句话。

@@ -2012,6 +2012,16 @@
data_type : x
optional : index, counts

- op : unpool
args: (Tensor x, Tensor indices, int[] ksize, int[] strides = {1,1}, int[] padding ={0,0} ,IntArray output_size = {0,0}, str data_format="NCHW")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

padding 修改为paddings

@sanbuphy sanbuphy requested a review from heavyrain-lzy April 26, 2023 04:55
@heavyrain-lzy
Copy link
Contributor

目前没什么问题,请rerun一下失败的PR,尤其是mac-python3

@sanbuphy
Copy link
Contributor Author

目前没什么问题,请rerun一下失败的PR,尤其是mac-python3

return还是挂

Copy link
Contributor

@heavyrain-lzy heavyrain-lzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 005fee1 into PaddlePaddle:develop Apr 28, 2023
@sanbuphy sanbuphy deleted the unpoolop branch April 28, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants