Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete SupportNPU(), SupportMLU() #52911

Merged
merged 2 commits into from
Apr 14, 2023
Merged

delete SupportNPU(), SupportMLU() #52911

merged 2 commits into from
Apr 14, 2023

Conversation

jjyaoao
Copy link
Contributor

@jjyaoao jjyaoao commented Apr 13, 2023

PR types

Others

PR changes

Others

Describe

#52319

@paddle-bot
Copy link

paddle-bot bot commented Apr 13, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -390,14 +390,7 @@ void ApplyDeviceGuard(const OperatorBase* op_base,
// when the Op that does not have NPUKernel is assigned to NPU, the
// CPUKernel will be executed and a warning will be given at the same
// time.
if (op_base->SupportNPU()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要删除整个分支

else if (op_device.find("npu") != std::string::npos &&
               platform::is_npu_place(place)) {

@jjyaoao jjyaoao requested a review from ronny1996 April 14, 2023 05:00
Copy link
Contributor

@ronny1996 ronny1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 8601859 into PaddlePaddle:develop Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants