[IR] OpTrait & OpInterface & OpInfo #52846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
… dev/new_ir_op_system
winter-wang
reviewed
Apr 21, 2023
| @@ -60,9 +60,9 @@ DictionaryAttributeStorage::ParamKey DictionaryAttributeStorage::GetAsKey() | |||
|
|
|||
| Attribute DictionaryAttributeStorage::GetValue(const StrAttribute &name) const { | |||
| if (size_ > 0) { | |||
There was a problem hiding this comment.
这儿的二分是不是可以直接 left = 0， right = size, 没必要判断size>0啊？
winter-wang
reviewed
Apr 21, 2023
paddle/ir/builtin_op.h
Outdated
| /// interface functions, and Model is a template class that defines the specific | ||
| /// implementation of interface functions based on template parameters. | ||
| /// | ||
| class InferShapeInterface : public OpInterfaceBase<InferShapeInterface> { |
There was a problem hiding this comment.
这个InferShapeInterface需要想办法跟paddle里面的phi里面的infershpe关联起来。
There was a problem hiding this comment.
好的，该内容已记录 Todo，Program 表示阶段进行开发。
winter-wang
reviewed
Apr 25, 2023
paddle/ir/ir_context.cc
Outdated
| registed_operations_.emplace(type_id, opinfo); | ||
| } | ||
|
|
||
| OpInfoImpl *GetOperation(ir::TypeId type_id) { |
There was a problem hiding this comment.
这个函数名是不是改成GetOpInfo更合适一点？
winter-wang
reviewed
Apr 25, 2023
paddle/ir/op_info_impl.h
Outdated
| template <typename T> | ||
| static void PlacementConstrctInterface( | ||
| std::pair<TypeId, void *> *&p_interface) { // NOLINT | ||
| void *ptmp = malloc(sizeof(typename T::template Model<ConcreteOp>)); |
There was a problem hiding this comment.
这儿为啥不直接p_interface->second = malloc(.......)呢？
Shixiaowei02
previously approved these changes
Apr 25, 2023
zhangbo9674
dismissed stale reviews from Shixiaowei02 and winter-wang
via
4464df4
|
Sorry to inform you that 4464df4's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Description
1. 主要内容
2. 各数据结构关系
Other
Pcard-67164