Hack auc for dense vector labels #5274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… refine_evaluator_ops
… hack_auc_for_multibin_labels
typhoonzero
changed the title
qingqing01
reviewed
Nov 1, 2017
paddle/cuda/src/hl_cuda_matrix.cu
Outdated
| } | ||
|
|
||
| void hl_vector_cast2int(int* out, real* vec, int size) { | ||
| keVectorCast2Int<<<1, 512>>>(out, vec, size); |
There was a problem hiding this comment.
Maybe better to keep same with the old framework.
keVectorCast2Int<<<1, 512, 0, STREAM_DEFAULT>>>(xxx);
CHECK_SYNC("hl_vector_cast2int failed");
paddle/math/Vector.cpp
Outdated
| } else { | ||
| for (size_t i = 0; i < getSize(); ++i) { | ||
| ret->getData()[i] = int(this->getData()[i]); | ||
| } |
There was a problem hiding this comment.
从这个函数的实现来，ret, this同在GPU上，或同在CPU上。
如果这样castToInt(bool useGpu)函数接口里的useGpu参数可以去掉，使用this的状态判断即可。
There was a problem hiding this comment.
All Done. Updated.
| // label width is 1 | ||
| CHECK_EQ(1, labelval->getWidth()); | ||
| auto tmp = labelval->getTranspose(); // do *not* copy | ||
| VectorPtr vec = Vector::create(tmp->getRowBuf(0), insNum, output->useGpu()); |
There was a problem hiding this comment.
Why call the getTranspose()?
Line 412 can write as follow?
VectorPtr vec = Vector::create(labelval->getData(), insNum, output->useGpu());| * @param[in] size size of the vector. | ||
| */ | ||
| extern void hl_vector_cast2int(int* out, real* vec, int size); | ||
|
|
There was a problem hiding this comment.
Maybe it also needs to add this function into the file cuda/include/stub/hl_matrix_stub.h for the ONLY_CPU compiling.
There was a problem hiding this comment.
Oh, thanks, this should be the correct way instead of add #ifdef in Vector.cpp
qingqing01
approved these changes
Nov 2, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5124
Fix #1291