Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Move Test] xpu #52661

Merged
merged 7 commits into from
Apr 12, 2023
Merged

[Move Test] xpu #52661

merged 7 commits into from
Apr 12, 2023

Conversation

RedContritio
Copy link
Contributor

@RedContritio RedContritio commented Apr 7, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Describe

移动 xpu 相关单测至 test/*

@paddle-bot
Copy link

paddle-bot bot commented Apr 7, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Apr 7, 2023
@RedContritio RedContritio mentioned this pull request Apr 7, 2023
Closed
tianshuo78520a
tianshuo78520a previously approved these changes Apr 10, 2023
View reviewed changes
Copy link
Collaborator

@tianshuo78520a tianshuo78520a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 非常感谢你的修改

@RedContritio
Copy link
Contributor Author

RedContritio commented Apr 11, 2023 •
edited
Loading

  • @XieYunshen 辛苦 approve 一下，单测目录迁移，没有进行单测条件的改动
  • @XiaoguangHu01 辛苦 approve，单测目录迁移，没有进行实质性的大规模文件变动

@luotao1 这个可以豁免吗，修改的有点多

XieYunshen
XieYunshen previously approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
单测目录迁移

zhiqiu
zhiqiu previously approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RedContritio RedContritio dismissed stale reviews from zhiqiu and XieYunshen via 8975439 April 11, 2023 06:11
@RedContritio
Copy link
Contributor Author

@luotao1 CI 全过了，辛苦豁免下 approve

@luotao1 luotao1 merged commit 9a7c83b into PaddlePaddle:develop Apr 12, 2023
@RedContritio RedContritio deleted the test_xpu branch April 12, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@XieYunshen XieYunshen XieYunshen left review comments

@zhiqiu zhiqiu zhiqiu left review comments

@tianshuo78520a tianshuo78520a Awaiting requested review from tianshuo78520a

Assignees

@luotao1 luotao1

@zhiqiu zhiqiu

@tianshuo78520a tianshuo78520a

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RedContritio @luotao1 @zhiqiu @tianshuo78520a @XieYunshen