Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rem cncl #52434

Merged
merged 23 commits into from
Apr 14, 2023
Merged

rem cncl #52434

merged 23 commits into from
Apr 14, 2023

Conversation

KimBioInfoStudio
Copy link
Contributor

@KimBioInfoStudio KimBioInfoStudio commented Apr 1, 2023 •
edited
Loading

PR types

Others

PR changes

Others

Describe

#52319

任务编号 任务内容 认领人 PR链接
12 清理 WITH_CNCL 相关代码 @KimBioInfoStudio #52434

split into small subtask
#52811

@paddle-bot
Copy link

paddle-bot bot commented Apr 1, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Apr 1, 2023
@KimBioInfoStudio KimBioInfoStudio mentioned this pull request Apr 1, 2023
Closed
ronny1996
ronny1996 previously approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@ronny1996 ronny1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Apr 3, 2023

请解决下冲突

@KimBioInfoStudio
Copy link
Contributor Author

请解决下冲突

Done

KimBioInfoStudio
KimBioInfoStudio commented Apr 3, 2023
View reviewed changes
paddle/fluid/pybind/imperative.cc Outdated Show resolved Hide resolved
paddle/fluid/pybind/imperative.cc Outdated Show resolved Hide resolved
paddle/fluid/operators/collective/c_allreduce_op.h Outdated Show resolved Hide resolved
paddle/fluid/imperative/reducer.h Outdated Show resolved Hide resolved
paddle/fluid/imperative/reducer.cc Outdated Show resolved Hide resolved
paddle/fluid/imperative/reducer.cc Outdated Show resolved Hide resolved
paddle/fluid/imperative/CMakeLists.txt Outdated Show resolved Hide resolved
@KimBioInfoStudio
Copy link
Contributor Author

@luotao1 ci 挂了，但是看不到报错

@luotao1
Copy link
Contributor

luotao1 commented Apr 12, 2023

很多写的都是【超时取消】，感觉像编译卡住了。PR-CI-Build的历史记录都是卡在某处
image

luotao1
luotao1 reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为文件不多，可以尝试分多个PR来删，看看具体是哪里的修改出问题了

@KimBioInfoStudio
Copy link
Contributor Author

因为文件不多，可以尝试分多个PR来删，看看具体是哪里的修改出问题了

good idea

@KimBioInfoStudio KimBioInfoStudio mentioned this pull request Apr 12, 2023
Merged
@KimBioInfoStudio
Copy link
Contributor Author

@ronny1996 @luotao1 pls help review

luotao1
luotao1 reviewed Apr 13, 2023
View reviewed changes
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

这个文件怎么改了这么多行呢，可以先revert或者只改必要的么

@KimBioInfoStudio
Copy link
Contributor Author

image

这个文件怎么改了这么多行呢，可以先revert或者只改必要的么

shfmt 自动改的，我的过，这个可以全部 revert 掉，需要跳过 ci 吗？

@luotao1 luotao1 merged commit 25bd5ed into PaddlePaddle:develop Apr 14, 2023
@luotao1
Copy link
Contributor

luotao1 commented Apr 14, 2023

image

python端还有一些cncl关键字需要删

@KimBioInfoStudio KimBioInfoStudio deleted the kim/rem_WITH_CNCL branch April 14, 2023 04:57
@KimBioInfoStudio
Copy link
Contributor Author

KimBioInfoStudio commented Apr 14, 2023 •
edited
Loading

image

python端还有一些cncl关键字需要删

will del in a new pr #52939 @luotao1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luotao1 luotao1 luotao1 approved these changes

@ronny1996 ronny1996 ronny1996 left review comments

Assignees

@luotao1 luotao1

@qili93 qili93

@ronny1996 ronny1996

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KimBioInfoStudio @luotao1 @ronny1996 @qili93