Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test Mv] asp_test #52141

Merged
merged 6 commits into from
Mar 29, 2023
Merged

[Test Mv] asp_test #52141

merged 6 commits into from
Mar 29, 2023

Conversation

gouzil
Copy link
Member

@gouzil gouzil commented Mar 25, 2023

PR types

Others

PR changes

Others

Describe

将python/paddle/fluid/tests/unittests/asp移动至test/asp

相关issues

@paddle-bot
Copy link

paddle-bot bot commented Mar 25, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Mar 25, 2023
@gouzil gouzil mentioned this pull request Mar 25, 2023
Closed
@gouzil
Copy link
Member Author

gouzil commented Mar 25, 2023

是否需要将 python/paddle/fluid/tests/unittests/CMakeLists.txt 下的 py_test_modules 方法进行迁移，我看有很多文件都使用了此方法

@tianshuo78520a
Copy link
Collaborator

是否需要将 python/paddle/fluid/tests/unittests/CMakeLists.txt 下的 py_test_modules 方法进行迁移，我看有很多文件都使用了此方法

已经有其他PR进行迁移了

@tianshuo78520a
Copy link
Collaborator

LGTM

zhiqiu
zhiqiu approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 2a8cfb5 into PaddlePaddle:develop Mar 29, 2023
@gouzil gouzil deleted the mv-asp-test branch May 15, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

Assignees

@luotao1 luotao1

@zhiqiu zhiqiu

@tianshuo78520a tianshuo78520a

Labels
contributor External developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gouzil @tianshuo78520a @zhiqiu @luotao1