【Hackathon No.62】增加pool3d算子BF16及单测，lgamma, masked_select FP16/BF16算子单测 #51837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
请核查一下是否具有API Check任务 |
co63oc
force-pushed
the
test20
branch
3 times, most recently
from
c779537 to
dd50307
Compare
已添加文件python/paddle/fluid/tests/unittests/test_pool3d_api.py 测试 test_static_bf16_gpu |
co63oc
force-pushed
the
test20
branch
3 times, most recently
from
a45ca8b to
d509f53
Compare
co63oc
changed the title
co63oc
changed the title
|
LGTM，但是需要解决一下CI问题 |
CI 已完成，PR-CI-Kunlun-KP-Build 是其他CI有同样问题 |
luotao1
previously approved these changes
Apr 4, 2023
ZzSean
previously approved these changes
Apr 4, 2023
| place = core.CUDAPlace(0) | ||
| if core.is_bfloat16_supported(place): | ||
| if core.is_compiled_with_rocm(): | ||
| self.check_output_with_place(place) |
| def test_check_output(self): | ||
| if core.is_compiled_with_cuda(): | ||
| place = core.CUDAPlace(0) | ||
| if core.is_bfloat16_supported(place): |
There was a problem hiding this comment.
测例前有skipIf，所以if core.is_compiled_with_cuda()和if core.is_bfloat16_supported(place)这两个判断可以去掉了
|
@co63oc 这两个小问题比较容易改，直接在这个PR里修改吧 |
已修改，CI已检查完成，PR-CI-Static-Check 是文档修改PR的检查 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
增加pool3d算子BF16及单测
增加lgamma FP16/BF16算子单测
文档修改 PaddlePaddle/docs#5758
增加masked_select FP16/BF16算子单测
文档修改 PaddlePaddle/docs#5767
有的BF16需要传入place参数，如果不传place出现找不到kernel函数错误