Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Zero-Dim] elementwise: onednn: support zero dimension inputs #51656

Merged
merged 1 commit into from
Mar 27, 2023
Merged

[Zero-Dim] elementwise: onednn: support zero dimension inputs #51656

merged 1 commit into from
Mar 27, 2023

Conversation

xinyu-intel
Copy link
Contributor

@xinyu-intel xinyu-intel commented Mar 14, 2023 •
edited
Loading

PR types

New features

PR changes

OPs

Describe

partial impl for #51364

@paddle-bot
Copy link

paddle-bot bot commented Mar 14, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Mar 14, 2023
@paddle-bot
Copy link

paddle-bot bot commented Mar 14, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@xinyu-intel xinyu-intel force-pushed the xinyu/onednn-0-d-binary branch 2 times, most recently from b26a27c to f119773 Compare March 15, 2023 06:40
@xinyu-intel xinyu-intel marked this pull request as ready for review March 17, 2023 03:45
@xinyu-intel
Copy link
Contributor Author

@zhouwei25 @YangQun1 Please help take a review. Thanks:)

@Silv3S Silv3S added the Intel label Mar 17, 2023
zhwesky2010
zhwesky2010 reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@zhwesky2010 zhwesky2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no other problem, LGTM

@zhwesky2010 zhwesky2010 changed the title elementwise: onednn: support zero dimension inputs [Zero-Dim] elementwise: onednn: support zero dimension inputs Mar 22, 2023
zhwesky2010
zhwesky2010 previously approved these changes Mar 22, 2023
View reviewed changes
YangQun1
YangQun1 previously approved these changes Mar 23, 2023
View reviewed changes
@xinyu-intel xinyu-intel dismissed stale reviews from YangQun1 and zhwesky2010 via 9d84977 March 23, 2023 02:30
@xinyu-intel xinyu-intel force-pushed the xinyu/onednn-0-d-binary branch from f119773 to 9d84977 Compare March 23, 2023 02:30
@jczaja jczaja self-requested a review March 27, 2023 07:36
jczaja
jczaja approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja jczaja merged commit 2c1d494 into PaddlePaddle:develop Mar 27, 2023
@paddle-bot
Copy link

paddle-bot bot commented Mar 27, 2023

你的PR已合入Paddle库，请关注后续测试结果。
Your PR has been merged into the repository. An official integration test will be conducted later. Stay tuned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jczaja jczaja jczaja approved these changes

@YangQun1 YangQun1 YangQun1 approved these changes

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees

@weishengying weishengying

Labels
contributor External developers Intel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xinyu-intel @jczaja @YangQun1 @zhwesky2010 @Silv3S @weishengying