add bf16 for some ops in static mode #51582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Xreki
reviewed
Mar 14, 2023
python/paddle/nn/clip.py
Outdated
| @@ -733,7 +733,7 @@ def _static_clip(self, params_grads): | |||
| merge_grad = merge_selected_rows(g) | |||
| merge_grad = get_tensor_from_selected_rows(merge_grad) | |||
| sum_square = _squared_l2_norm(merge_grad) | |||
| if sum_square.dtype == core.VarDesc.VarType.FP16: | |||
| if sum_square.dtype == core.VarDesc.VarType.FP16 or sum_square.dtype == core.VarDesc.VarType.BF16: | |||
There was a problem hiding this comment.
fp16和bf16的结果还是分开存储吧，且需要检查，fp16和bf16不能同时存在。
There was a problem hiding this comment.
develop branch里面把这个给改掉了
Xreki
pushed a commit
to Xreki/Paddle
that referenced
this pull request
Apr 9, 2023
aoyulong
pushed a commit
that referenced
this pull request
Apr 9, 2023
* Cherry-pick the register of bfloat16 for amp_kernel, pull request #45541. * Cherry-pick the master_grad support of adamw, pull request #51141. * add bf16 for some ops in static mode (#51582) * Add bfloat16 support for some api in static mode. * Fix codestyle. * Revert the change of layer_function_generator.py. --------- Co-authored-by: Shaojie WANG <wsjmessi@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
add bf16 datatype for some ops in static mode