Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stablity of Paddle-TensorRT FP16 UT GitHub (1) #51554

Merged
merged 3 commits into from
May 19, 2023
Merged

Improve stablity of Paddle-TensorRT FP16 UT GitHub (1) #51554

merged 3 commits into from
May 19, 2023

Conversation

eee4017
Copy link
Contributor

@eee4017 eee4017 commented Mar 13, 2023 •
edited
Loading

PR types

Function optimization

PR changes

Others

Description

This Pull Request consists of the following changes:

  1. In engine.cc, a temporary blacklist function IsFP16BlacklistLayer has been added for Conv2D layers due to a bug in TensorRT versions 8.6.1.0 and later. This function prevents precision settings on Conv2D layers to mitigate the issue until the TensorRT team provides a permanent fix.
  2. Also in engine.cc, we ensure that only valid layers are processed in FP16 mode.
  3. In auto_scan_test.py, the logging level has been made configurable via the PADDLE_TEST_LOGLEVEL environment variable.
  4. Several log messages have been modified to use f-strings for more readable code.
  5. In program_config.py, a new method has been added to change the data type of the tensor's data.

@paddle-bot
Copy link

paddle-bot bot commented Mar 13, 2023

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Mar 13, 2023
@paddle-bot
Copy link

paddle-bot bot commented Mar 13, 2023

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@eee4017 eee4017 force-pushed the improve_stablity_of_paddletrt_fp16_ut_github branch from ab27394 to 78786f6 Compare March 13, 2023 08:32
@eee4017 eee4017 changed the title Improve stablity of paddletrt fp16 ut GitHub Improve stablity of paddletrt fp16 ut GitHub (1) Mar 15, 2023
@eee4017 eee4017 force-pushed the improve_stablity_of_paddletrt_fp16_ut_github branch from 78786f6 to 2ad680e Compare March 19, 2023 16:03
@Wangzheee Wangzheee requested a review from jiweibo April 13, 2023 07:54
@eee4017 eee4017 force-pushed the improve_stablity_of_paddletrt_fp16_ut_github branch from 2ad680e to 7311b0b Compare April 14, 2023 06:12
@yuanlehome yuanlehome mentioned this pull request Apr 17, 2023
Merged
@yuanlehome
Copy link
Contributor

Hi, is this work still being followed up?

@eee4017 eee4017 force-pushed the improve_stablity_of_paddletrt_fp16_ut_github branch from 6217f90 to 4c9d87d Compare April 17, 2023 06:50
@eee4017 eee4017 marked this pull request as ready for review April 17, 2023 06:53
@eee4017
Copy link
Contributor Author

eee4017 commented Apr 17, 2023

Hi, is this work still being followed up?

Yes, the commit is going to be reviewed. In order to adhere to the contribution guidelines, it will be divided into multiple pull requests. Thanks.

@eee4017 eee4017 force-pushed the improve_stablity_of_paddletrt_fp16_ut_github branch 4 times, most recently from c806b65 to 409ecbb Compare April 17, 2023 08:03
@jiweibo jiweibo requested review from yuanlehome and zhangjun April 17, 2023 10:54
@eee4017 eee4017 force-pushed the improve_stablity_of_paddletrt_fp16_ut_github branch 6 times, most recently from 4993445 to f81a8af Compare April 19, 2023 04:33
@eee4017 eee4017 force-pushed the improve_stablity_of_paddletrt_fp16_ut_github branch 2 times, most recently from 778db83 to e5a9933 Compare May 8, 2023 06:47
jzhang533
jzhang533 previously approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qingqing01
qingqing01 previously approved these changes May 9, 2023
View reviewed changes
@eee4017 eee4017 closed this May 10, 2023
@eee4017 eee4017 reopened this May 10, 2023
@paddle-bot
Copy link

paddle-bot bot commented May 10, 2023

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@eee4017 eee4017 closed this May 10, 2023
@eee4017 eee4017 reopened this May 10, 2023
@paddle-bot
Copy link

paddle-bot bot commented May 10, 2023

很抱歉，经过我们的反复讨论，你的PR暂未达到合入标准，请阅读飞桨原生算子开发规范，你可以重新提交新的PR，我们先将此PR关闭，感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@eee4017 eee4017 force-pushed the improve_stablity_of_paddletrt_fp16_ut_github branch from e5a9933 to 814b189 Compare May 10, 2023 03:00
@eee4017 eee4017 dismissed stale reviews from qingqing01 and jzhang533 via fd1fe80 May 15, 2023 01:36
@eee4017 eee4017 force-pushed the improve_stablity_of_paddletrt_fp16_ut_github branch 3 times, most recently from c36e85d to 30d982f Compare May 17, 2023 03:25
jzhang533
jzhang533 previously approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eee4017 eee4017 force-pushed the improve_stablity_of_paddletrt_fp16_ut_github branch from 30d982f to f15b894 Compare May 19, 2023 01:38
yuanlehome
yuanlehome approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@yuanlehome yuanlehome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heavengate heavengate merged commit 645e81f into PaddlePaddle:develop May 19, 2023
@jeng1220 jeng1220 mentioned this pull request May 25, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanlehome yuanlehome yuanlehome approved these changes

@qingqing01 qingqing01 qingqing01 approved these changes

@jiweibo jiweibo jiweibo left review comments

@zhangjun zhangjun zhangjun left review comments

@jzhang533 jzhang533 jzhang533 left review comments

Assignees

@heavengate heavengate

Labels
contributor External developers NVIDIA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@eee4017 @CLAassistant @yuanlehome @qingqing01 @jzhang533 @zhangjun @jiweibo @heavengate @zlsh80826