Batch norm latest #5103
Merged
Batch norm latest #5103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
reviewed
Oct 25, 2017
| x_val, scale_val, bias_val, epsilon, "NHWC") | ||
|
|
||
| # | ||
| mean_out = saved_mean * (1. - momentum) + momentum * mean |
There was a problem hiding this comment.
these three line can be moved to _reference_training
jacquesqiao
reviewed
Oct 27, 2017
| @@ -200,12 +307,14 @@ def test_with_place(place): | |||
| self.__assert_close(x_grad_tensor, x_grad_ref, "x_grad") | |||
| self.__assert_close(scale_grad_tensor, scale_grad_ref, "scale_grad") | |||
| self.__assert_close(bias_grad_tensor, bias_grad_ref, "bias_grad") | |||
| print "op test backward passed: ", tensor_format | |||
|
|
|||
| places = [core.CPUPlace()] | |||
| if core.is_compile_gpu() and core.op_support_gpu("batch_norm"): | |||
| places.append(core.GPUPlace(0)) | |||
| for place in places: | |||
| test_with_place(place) | |||
There was a problem hiding this comment.
可以加一层循环，把TensorFormat作为参数传给 test_with_place_and_dataformat
There was a problem hiding this comment.
把四种case都测试到
CPU NCHW
CPU NWHC
GPU NCHW
GPU NWHC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with both NCHW and NHWC passed.