Add multi_precision for adagrad op #50078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaTrainingG
force-pushed
the
adagrad
branch
2 times, most recently
from
9f7eb7d to
86432cc
Compare
AnnaTrainingG
force-pushed
the
adagrad
branch
from
b4d455d to
98f9b6f
Compare
Shixiaowei02
approved these changes
Mar 3, 2023
jiweibo
approved these changes
Mar 3, 2023
| MT param_out_data = | ||
| in - (lr_data * grad_data) / (sqrt(moment_out_data) + epsilon); | ||
|
|
||
| param_out[i] = static_cast<MT>(param_out_data); |
There was a problem hiding this comment.
这里是不是应该改成 param_out[i] = static_cast< T >(param_out_data);
There was a problem hiding this comment.
#51790 修复PR 已提交
| def _create_accumulators(self, block, parameters): | ||
| assert isinstance(block, framework.Block) | ||
|
|
||
| if isinstance(parameters, dict): | ||
| parameters = self._update_param_group(parameters) | ||
|
|
||
| for p in parameters: | ||
| if self._multi_precision and p.dtype == core.VarDesc.VarType.FP16: | ||
| master_p = self._create_master_weight(p) | ||
| self._add_accumulator(self._moment_acc_str, master_p) |
There was a problem hiding this comment.
此处是不是缺少fill_value=self.initial_accumulator_value？
There was a problem hiding this comment.
#51790 修复PR已经提交
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
APIs
Describe
给 adagrad api 新增multi_precision 参数用于AMP O2训练