Fix Python IndexError of case4: paddle.optimizer.lr.PiecewiseDecay #49987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
python/paddle/optimizer/lr.py
Outdated
Comment on lines
391
to
402
| if len(boundaries) > 0: | ||
| pass | ||
| else: | ||
| raise ValueError('The boundaries cannot be empty.') | ||
|
|
||
| if len(values) >= len(boundaries): | ||
| pass | ||
| else: | ||
| raise ValueError( | ||
| f'The length ({len(values)}) of values should >= length ({len(boundaries)}) of boundaries.' | ||
| ) | ||
|
|
There was a problem hiding this comment.
调整一下if的判断，pass的逻辑可以不写，只写raise部分。
zhwesky2010
reviewed
Jan 31, 2023
zhwesky2010
approved these changes
Feb 2, 2023
好的，之后会在 docs 里进行对应 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
Solution