-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[inference][trt]Upgrade expand cast nearestinterp for sd #48998
[inference][trt]Upgrade expand cast nearestinterp for sd #48998
Conversation
你的PR提交成功,感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nvinfer1::Dims stride; | ||
stride.nbDims = nbDims_num; | ||
stride.nbDims = shape_rank; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
后续可以添加上expand的converter注册
@@ -34,6 +25,7 @@ class NearestInterpolateOpConverter : public OpConverter { | |||
|
|||
framework::OpDesc op_desc(op, nullptr); | |||
|
|||
auto inputs = op_desc.Inputs(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个变量有用到吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个变量有用到吗?
下个PR删掉
@@ -2295,7 +2288,8 @@ struct SimpleOpTypeSetTeller : public Teller { | |||
} | |||
} | |||
#endif | |||
if (!((in_dtype == 5 || in_dtype == 4 || in_dtype == 2) && | |||
if (!((in_dtype == 5 || in_dtype == 4 || in_dtype == 3 || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
后面把类似的写法改成 static_cast(PROTO_FLOAT) 类似的写法吧
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
下一个PR就全给去掉了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR types
Others
PR changes
Others
Describe