Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ninja compile error #48435

Merged
merged 4 commits into from
Nov 29, 2022
Merged

Conversation

phlrain
Copy link
Collaborator

@phlrain phlrain commented Nov 28, 2022

PR types

Bug fixes

PR changes

Others

Describe

修复linux 平台下, ninja 编译的错误

ninja需要提前知道所有依赖的库的生成方式, make可以边运行,边查找

解决ninja的需求,仅需要声明 BUILD_BYPRODUCTS

@paddle-bot
Copy link

paddle-bot bot commented Nov 28, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phlrain phlrain merged commit 8591480 into PaddlePaddle:develop Nov 29, 2022
@zlsh80826 zlsh80826 mentioned this pull request Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants