Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for Collective Default Stream #48308

Conversation

JZ-LIANG
Copy link
Contributor

@JZ-LIANG JZ-LIANG commented Nov 24, 2022

PR types

Bug fixes

PR changes

Others

Describe

Originally Collective Op get default stream from a global device ctx pool, which obstacles executor to schedule multiple custom streams in Static mode.
PR: Collective Op get default stream from execution ctx and executor change this stream to assign op a custom stream in Static mode .

@paddle-bot
Copy link

paddle-bot bot commented Nov 24, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@LiYuRio LiYuRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aoyulong aoyulong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JZ-LIANG JZ-LIANG merged commit a66bb67 into PaddlePaddle:develop Nov 29, 2022
@JZ-LIANG JZ-LIANG changed the title Bugfix for Collective default calc stream Bugfix for Collective Default Stream Nov 29, 2022
JZ-LIANG added a commit to JZ-LIANG/Paddle that referenced this pull request Dec 5, 2022
* get default calc stream from execution ctx instead of global dev ctx pool.
JZ-LIANG added a commit to JZ-LIANG/Paddle that referenced this pull request Dec 28, 2022
* get default calc stream from execution ctx instead of global dev ctx pool.
LiYuRio pushed a commit to LiYuRio/Paddle that referenced this pull request Apr 6, 2023
* get default calc stream from execution ctx instead of global dev ctx pool.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants