[Zero-Dim] Make auto parallel judge dim more strict #47961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
✅ This PR's description meets the template requirements! |
zhwesky2010
changed the title
zhwesky2010
force-pushed
the
0D_auto_parallel
branch
2 times, most recently
from
753e871 to
15fc86a
Compare
zhwesky2010
changed the title
jeff41404
reviewed
Nov 15, 2022
| @@ -1540,7 +1540,7 @@ def _get_op_by_id(ops, id): | |||
| input_var | |||
| ).dims_mapping | |||
| else: | |||
| if fwd_op_dist_attr.get_input_dims_mapping(input_name): | |||
| if input_name in forward_op.input_arg_names: | |||
There was a problem hiding this comment.
L1242 have same condition with here, need to be modified together?
zhwesky2010
force-pushed
the
0D_auto_parallel
branch
from
15fc86a to
bd77569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
修复模型报错。
使自动并行获取dim时的判断更严格，由于原本采用
if ref_dims_mapping的方式，但当 dim=[]（表示0D Tensor的shape）时，[]在python语法里会被当成False，与None等同。因此使这里的判断更严格，区分[]与None的不同。
[]的shape在网络中打印出来如下（注：[]是Tensor.shape的一种正确形式，与None不同）：