Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeStyle] fix macos inconsistent-missing-override warnings and add -Werror #47264

Merged
merged 2 commits into from
Oct 24, 2022
Merged

[CodeStyle] fix macos inconsistent-missing-override warnings and add -Werror #47264

merged 2 commits into from
Oct 24, 2022

Conversation

GreatV
Copy link
Contributor

@GreatV GreatV commented Oct 22, 2022

PR types

Others

PR changes

Others

Describe

fix macos inconsistent-missing-override warnings

➜ cat ./before.log | grep "\[\-W" |grep -v party | awk '{print $NF}'|sort|uniq -c|sort -nr  
 743 [-Winconsistent-missing-override]
  25 [-Wnon-c-typedef-for-linkage]
  23 [-Wdeprecated-declarations]
  10 [-Wbraced-scalar-init]
   7 [-Wdangling-gsl]
   4 [-Walign-mismatch]
   3 [-Wc++17-extensions]
   2 [-Wexceptions]
   1 [-Wuninitialized]
   1 [-Wtautological-constant-out-of-range-compare]
   1 [-Wreturn-type-c-linkage]
   1 [-Wpragma-pack]
   1 [-Wliteral-conversion]
➜ cat ./after.log | grep "\[\-W" |grep -v party | awk '{print $NF}'|sort|uniq -c|sort -nr
  25 [-Wnon-c-typedef-for-linkage]
  23 [-Wdeprecated-declarations]
  10 [-Wbraced-scalar-init]
   7 [-Wdangling-gsl]
   4 [-Walign-mismatch]
   3 [-Wc++17-extensions]
   2 [-Wexceptions]
   1 [-Wuninitialized]
   1 [-Wtautological-constant-out-of-range-compare]
   1 [-Wreturn-type-c-linkage]
   1 [-Wpragma-pack]
   1 [-Wliteral-conversion]

@paddle-bot
Copy link

paddle-bot bot commented Oct 22, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Oct 22, 2022
@GreatV
Copy link
Contributor Author

GreatV commented Oct 22, 2022

@luotao1 @zhiqiu

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@luotao1 luotao1 merged commit c5fe109 into PaddlePaddle:develop Oct 24, 2022
@GreatV GreatV deleted the fix_macos_warning branch October 24, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor External developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants