Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom Device] Add singleton to custom device #46963

Merged
merged 2 commits into from
Oct 17, 2022

Conversation

YanhuiDua
Copy link
Contributor

@YanhuiDua YanhuiDua commented Oct 12, 2022

PR types

Performance optimization

PR changes

APIs

Describe

Add singleton to GetDeviceCount() in custom_device.cc to avoid repeated calls for different devices

@paddle-bot
Copy link

paddle-bot bot commented Oct 12, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Oct 12, 2022

✅ This PR's description meets the template requirements!
Please wait for other CI results.

qili93
qili93 previously approved these changes Oct 13, 2022
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ronny1996
ronny1996 previously approved these changes Oct 13, 2022
Init device_init_flag_ in default
@YanhuiDua YanhuiDua dismissed stale reviews from ronny1996 and qili93 via 0b9dc28 October 13, 2022 11:36
@YanhuiDua YanhuiDua changed the title [Custon Device] Add singleton to custom device [Custom Device] Add singleton to custom device Oct 17, 2022
Copy link
Contributor

@qili93 qili93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qili93 qili93 merged commit 73196e5 into PaddlePaddle:develop Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants