add maximum limit for grid of index_select #41127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
ZzSean
reviewed
Mar 30, 2022
| @@ -21,6 +21,15 @@ | |||
|
|
|||
| namespace phi { | |||
|
|
|||
| namespace { | |||
| template <typename Context> | |||
| void LimitGridDim(const Context& ctx, unsigned int* grid_dim) { | |||
There was a problem hiding this comment.
这个函数是不是可以抽取出来，放在公共的文件中，不用每个算子都再定义一次？
There was a problem hiding this comment.
已经挪动至paddle/fluid/platform/device/gpu/gpu_launch_config.h中。
FlyingQianMM
force-pushed
the
develop_index
branch
from
fc66134 to
417f5a5
Compare
FlyingQianMM
force-pushed
the
develop_index
branch
from
417f5a5 to
841c148
Compare
ZzSean
reviewed
Apr 1, 2022
| stream>>>(in_grad_data, numel); | ||
| int block_dim = 256; | ||
| dim3 grid_dim = | ||
| dim3((numel + PADDLE_CUDA_NUM_THREADS - 1) / PADDLE_CUDA_NUM_THREADS); |
There was a problem hiding this comment.
这里block和grid的设置没有对应上，设置了block dim为256，grid就应该向上对齐block_dim，PADDLE_CUDA_NUM_THREADS是512
ZzSean
reviewed
Apr 1, 2022
FlyingQianMM
force-pushed
the
develop_index
branch
from
dd7fb6c to
acfcfe7
Compare
YuanRisheng
approved these changes
Apr 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
The grid number of index_select has not been limited, which may raise a bug like:
So we add a maximum limit for grid of index_select kernel.