Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Phi] Rename ScalarArray to IntArray #40975

Merged
merged 10 commits into from
Mar 31, 2022
Merged

[Phi] Rename ScalarArray to IntArray #40975

merged 10 commits into from
Mar 31, 2022

Conversation

zyfncg
Copy link
Contributor

@zyfncg zyfncg commented Mar 26, 2022 •
edited
Loading

PR types

Others

PR changes

Others

Describe

将ScalarArray更名为IntArray。

  • ScalarArray在设计之初是用来解决shape或者索引参数存在多种数据类型的问题#PR37409，即将vector，Tensor和vector三种表示shape或者索引下标的数据类型统一表示为ScalarArray，所以ScalarArray最初仅支持int类型数据。
  • 随着大部分的算子完成迁移，基本可以验证只支持int类型的ScalarArray可以满足目前框架算子体系的需求。
  • ScalarArray在只支持int类型的设计下，使用IntArray的命名在功能描述上更为准确，因此本PR中将ScalarArray更名为IntArray。

YuanRisheng
YuanRisheng previously approved these changes Mar 29, 2022
View reviewed changes
chenwhql
chenwhql previously approved these changes Mar 29, 2022
View reviewed changes
ZzSean
ZzSean previously approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op-benchmark

ZzSean
ZzSean approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@ZzSean ZzSean left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark

XiaoguangHu01
XiaoguangHu01 approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zyfncg zyfncg merged commit e559fe4 into PaddlePaddle:develop Mar 31, 2022
@zyfncg zyfncg deleted the int_array branch March 31, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@ZzSean ZzSean ZzSean approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@chenwhql chenwhql chenwhql left review comments

@MingMingShangTian MingMingShangTian MingMingShangTian left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zyfncg @MingMingShangTian @chenwhql @YuanRisheng @ZzSean @XiaoguangHu01